[Marwin]

Hello! 

I'm working on increasing guild rank limitations, becouse default number of ranks (10) is very annoying and for some our guilds it's simple not enough. In Guild.h i changed: 

GUILD_RANKS_MAX_COUNT               = 10,

to

GUILD_RANKS_MAX_COUNT               = 20,

 

It works, but after the server restart, all records in guild_rank DB table are erased and replaced with default 5 ranks. Propably it's becouse of "calculate guild limitations" process on the end of starting worldserver. On TrinityCore github they closed the issue, becouse it's client modifications. So... Dear Model Changing users, do u know, where is the column or value for that limit?

 

Working on latest 3.3.5a TrinityCore. 

 

[Marwin]

Solved, now we have to edit the UI.   

[Marwin]

So, now it works fine on the server side, but it's creepy on the client side. UI is still coded for some max rank limit, so... Do u have any idea, where is hidden the lua/xml code for edit this list in guild control? 

https://prnt.sc/mjuu7k

It's the last, cosmetic step. Ranks work fine, with every functionality as usually. After I solve that cosmetic issue, i will release all of my code changes and cosmetic patch. Maybe it's useful for some RP projects with large RolePlaying guilds (that's the reason why we are modding this). After that modifications, u can have guilds with 30 ranks and more.  

[Marwin]

Still don't know where is that creepy value hidden. Any ideas?  Could it be hardcoded in WoW.exe? 

[Смердокрыл]

https://github.com/Resike/BlizzardInterfaceCode/blob/live/Interface/AddOns/Blizzard_GuildControlUI/Blizzard_GuildControlUI.lua

MAX_GUILDRANKS = 10;

 

[Marwin]

That's file from 8.1.0 (BfA) version. 3.3.5a doesn't have even Blizzard GuildControlUI folder, so... Propably the dead end. Still searching.  

[Roarl]

If the lua interface file appeared only in BFA I really think it makes sense it was hardcoded before. Looking into it as well.